Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: upgrade wagmi package to support wagmi 0.8.x #445

Merged
merged 6 commits into from
Jan 27, 2023

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Jan 26, 2023

This PR is an iteration of #441 adjusting the wagmi example app and also using less restrictive version range for wagmi.

Fixes #432

Bulding block for web3modal v2 support (as they use wagmi)

@changeset-bot
Copy link

changeset-bot bot commented Jan 26, 2023

🦋 Changeset detected

Latest commit: f53a45b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@gnosis.pm/safe-apps-wagmi Major
example-safe-apps-wagmi-cra Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@mmv08 mmv08 mentioned this pull request Jan 26, 2023
'@gnosis.pm/safe-apps-wagmi': major
---

This version is bumping versions of wagmi and web3modal in order to work with wagmi0.10.10 and the latest web3modal
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not able to find changes related to web3modal. Only wagmi

@mmv08 mmv08 force-pushed the feature/wagmi-upgrade branch from 44fddba to d719e9a Compare January 27, 2023 10:05
@mmv08 mmv08 requested a review from dasanra January 27, 2023 11:03
@dasanra
Copy link
Collaborator

dasanra commented Jan 27, 2023

Rolled back some dependencies as a very fast bump was causing issues for me. Now it should be balanced. I suspect some previous changes broke some flows

@mmv08 mmv08 merged commit 8a1d38b into development Jan 27, 2023
@mmv08 mmv08 deleted the feature/wagmi-upgrade branch January 27, 2023 12:59
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants